fix typing for get_auto_imports, get_namespace, and run_formatters #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
May 11, 2025
| @@ -18,4 +19,6 @@ def get_command_line_option(argv: Sequence[Any], option: Any) -> Any | None: ... | |||
| def normalize_path_patterns(patterns: Iterable[str]) -> list[str]: ... | |||
| def is_ignored_path(path: StrPath, ignore_patterns: Iterable[str]) -> bool: ... | |||
| def find_formatters() -> dict[str, str | None]: ... | |||
| def run_formatters(written_files: Sequence[StrOrBytesPath], black_path: str = ...) -> None: ... | |||
| def run_formatters( | |||
| written_files: Sequence[StrOrBytesPath], black_path: str = ..., stderr: object = sys.stderr | |||
There was a problem hiding this comment.
Please, also make sure that import _typeshed is there
Suggested change
| written_files: Sequence[StrOrBytesPath], black_path: str = ..., stderr: object = sys.stderr | |
| written_files: Sequence[StrOrBytesPath], black_path: str = ..., stderr: _typeshed.SupportsWrite[str] = ..., |
jose-reveni
pushed a commit
to jose-reveni/django-stubs
that referenced
this pull request
Jun 9, 2025
…ypeddjango#2674) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: sobolevn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed type hints for run_formatter method. Added type hints for get_auto_imports and get_namespace methods
Format is:
django.core.managementfor 5.2 #2672django.core.managementfor 5.2 #2672