Fix reveal_type to return its argument
#2716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Kaseorg <[email protected]>
We might, but instead I would suggest using It is not cool to crash mypy, when you left unimported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reveal_typecan be used in the middle of an expression, as infunc(reveal_type(obj)), so it needs to return its argument at runtime.By the way,
typing.reveal_typewas added to the runtime library in Python 3.11, and also astyping_extensions.reveal_typefor all Python versions in typing-extensions 4.1.0, so this monkey-patch is not really needed anymore—maybe we should turn it off by default.