Make some mixin methods generic #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
reviewed
Feb 2, 2021
| class CreateModelMixin: | ||
| def create(self, request: Request, *args: Any, **kwargs: Any) -> Response: ... | ||
| def perform_create(self, serializer: BaseSerializer) -> None: ... | ||
| def perform_create(self: UsesQuerySet[_MT], serializer: BaseSerializer[_MT]) -> None: ... |
There was a problem hiding this comment.
Wow, I didn't know you could do that 😮 nice.
There was a problem hiding this comment.
@intgr mypy has a section on "Advanced self-types". Pretty cool feature! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes certain mixin methods generic using a protocol for the self type. This ensures that the queryset and instance arguments for the methods have specific types based on the model instead of
BaseSerializer[Any]andModel. ForCreateModelMixinandUpdateModelMixinthis isn't a huge deal, because you were already allowed to overrideBaseSerializerwith e.g.BaseSerializer[MyModel](the tests I've included for those actually pass even without the change). It can probably still be useful in some niche cases though. ForDestroyModelMixinit's a big win since overridingModelwithMyModelwould produce an error without this change.