Skip to content

Fix errors in CI #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Fix errors in CI #273

merged 1 commit into from
Nov 7, 2022

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Nov 3, 2022

Thanks to @andersk for related fix in django-stubs: typeddjango/django-stubs#1123

@intgr intgr mentioned this pull request Nov 7, 2022
@intgr intgr force-pushed the fix-ci branch 2 times, most recently from 2b9c847 to 99a7cb9 Compare November 7, 2022 22:14
@intgr intgr marked this pull request as ready for review November 7, 2022 22:19
@intgr intgr changed the title Try to fix errors in CI Fix errors in CI Nov 7, 2022
@intgr
Copy link
Contributor Author

intgr commented Nov 7, 2022

@sobolevn Looks like I did it. We're not yet compatible with django-stubs 1.13.0, but let's take it one step at a time.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit ec5ecd4 into typeddjango:master Nov 7, 2022
intgr added a commit to mvandenburgh/djangorestframework-stubs that referenced this pull request Nov 16, 2022
HEAD was already added to _MIXED_CASE_HTTP_VERBS in typeddjango#273, but I missed _LOWER_CASE_HTTP_VERBS there.
intgr added a commit that referenced this pull request Nov 16, 2022
* Add 'HEAD' to accepted HTTP verbs list

* Fixes after rebase (ec5ecd4)

HEAD was already added to _MIXED_CASE_HTTP_VERBS in #273, but _LOWER_CASE_HTTP_VERBS was missed.

Co-authored-by: Marti Raudsepp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants