Skip to content

Update recommended mypy & CI to 1.1.1 #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2023
Merged

Update recommended mypy & CI to 1.1.1 #374

merged 2 commits into from
Mar 11, 2023

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Mar 10, 2023 •
edited
Loading

  • Updated mypy to 1.1.1 for compatible-mypy and CI
  • Minor tweak needed to typecheck ignores

Related issues

intgr
intgr commented Mar 10, 2023
View reviewed changes
requirements.txt
@@ -7,6 +7,6 @@ djangorestframework==3.14.0
types-pytz==2022.7.1.2
types-requests==2.28.11.15
types-urllib3==1.26.25.8
django-stubs==1.15.0
git+https://github.com/typeddjango/django-stubs@update-mypy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO revert when django-stubs is released before merging this!

Suggested change
git+https://github.com/typeddjango/django-stubs@update-mypy
django-stubs==1.16.0

@intgr intgr added the help wanted Extra attention is needed label Mar 10, 2023
@intgr intgr mentioned this pull request Mar 10, 2023
Closed
sobolevn
sobolevn approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, or we can wait for a new django-stubs release before merging this.

@intgr intgr merged commit 49b4c5f into typeddjango:master Mar 11, 2023
@intgr
Copy link
Contributor Author

intgr commented Mar 11, 2023

Ooooops, before my morning coffee, I forgot I was supposed to wait for django-stubs release. Oh well, I can fix it later 😅

@intgr intgr deleted the update-mypy branch March 11, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @sobolevn