Group hufilter lists together #28102
-
Hi. First of all, thanks for the extension and the huge effort to maintain it! uBlock includes the hufilter regional list by default, however the hufilter project also has an optional, "self-promotions" list to enable. It would be great if this list would be grouped under the default hufilter list in the settings page, like the polish or russian lists: ![]() I have understood that requesting new filter lists is prohibited, but I think this optional list is part of the hufilter project and should be included, especially as the default list is already included. I have added the changes in https://github.com/gorhill/uBlock/compare/master...gergelypap:feat/add-hufilter-list?expand=1 but pull requests are obviously disallowed. @gorhill @scripthunter7 What do you think? |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 2 replies
-
If it is for self-promotion, the list should not be enabled by default. |
Beta Was this translation helpful? Give feedback.
-
@gergelypap Your first contribution must be approved by gorhill, after that you will have the opportunity to open a PR. By the way, hufilter currently contains an increasingly large annoyance section, but this can be modified at any time to be built into a separate list. I think it would be useful to separate it sometime in the future |
Beta Was this translation helpful? Give feedback.
-
We don't really consider all kinds of sublists in regional lists, especially if they are just for self-promotion or annoyances. Note that the sublists included in Russian and Polish lists are for anti-adblock or malware/phishing sites. These are important enough to be listed there. |
Beta Was this translation helpful? Give feedback.
-
Got it. Actually, there is a Hungarian list against phishing that you could consider adding: https://github.com/FakesiteListHUN/FakeWebshopListHUN The creator wanted to include it in hufilter somehow, but it's probably easier for everyone if it remains a separate list. |
Beta Was this translation helpful? Give feedback.
We don't really consider all kinds of sublists in regional lists, especially if they are just for self-promotion or annoyances. Note that the sublists included in Russian and Polish lists are for anti-adblock or malware/phishing sites. These are important enough to be listed there.