fix(screenshot): Correct segment calculation to prevent duplication

[leoric-crown]

Summary

This commit replaces the previous calculation with the correct integer-based ceiling division formula:
num_segments = (page_height + viewport_height - 1) // viewport_height async_crawler_strategy.py#1432

Fixes #1187

List of files changed and why

async_crawler_strategy.py - Wrong segment calculation was duplicating screenshot content (generating 2 segments of full page screenshots)

How Has This Been Tested?

Basic testing by updating the offending line and observing results.

Checklist:

• My code follows the style guidelines of this project (I only edited one line)
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (didn't find it necessary since only one line edit)
• I have made corresponding changes to the documentation
• I have added/updated unit tests that prove my fix is effective or that my feature works - No. Could not figure out how to set up tests, sorry.
• New and existing unit tests pass locally with my changes - No. Could not figure out how to set up tests, sorry.

Summary by CodeRabbit

• Bug Fixes
  • Improved the accuracy of scrolling and screenshot stitching to ensure full-page captures without unnecessary extra segments.

[coderabbitai]

Walkthrough

The change updates the calculation of the number of segments used for scrolling and screenshot stitching in the take_screenshot_scroller method of the AsyncPlaywrightCrawlerStrategy class. The calculation now uses a ceiling division formula to correctly compute the minimum number of segments needed, replacing the previous formula that always added an extra segment.

Changes

File(s)	Summary of Changes
crawl4ai/async_crawler_strategy.py	Updated the calculation of the number of segments for scrolling in take_screenshot_scroller method from (page_height // viewport_height) + 1 to (page_height + viewport_height - 1) // viewport_height to avoid unnecessary extra segments.

Assessment against linked issues

Objective	Addressed	Explanation
Fix duplicated screenshot content in /screenshots endpoint (#1187)	✅

Poem

🐇 In code I hopped with nimble feet,
Counting segments, making them neat.
No more repeats, just one true scroll,
Stitching pages to make them whole.
A rabbit’s fix, so crisp and bright,
Screenshots now just right! 📸✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09c9f8d and 85fc945.

📒 Files selected for processing (1)

• crawl4ai/async_crawler_strategy.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crawl4ai/async_crawler_strategy.py

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4bb0cc and 09c9f8d.

📒 Files selected for processing (1)

• crawl4ai/async_crawler_strategy.py (1 hunks)