Cldr 18165/GitHub sso reload #4647
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLDR-18165 cla: github sso: generate login url - add LoginManager to manage the sso CLDR-18165 cla: github sso: scaffolding and login mechanisms - add LoginSession abstraction - remove unused dependency - add STRestClient for simplifying REST calls - cleanup hashtable in CookieSession (slightly) - add simplified api in WebContext for retrieving sessions with less drama CLDR-18165 cla: github sso: SameSite=Lax is what we need - Strict cookies DO NOT get sent by browsers after redirect, breaking our session model Discussed at: https://www.nogginbox.co.uk/blog/strict-cookies-not-sent-by-request CLDR-18165 cla: github sso: cla signing scaffolding CLDR-18165 cla: github sso: remainder of auth scaffolding
- need to fix L&F but all features are there
- use <a-row> and <a-col> - explain error cases
- re-add CLA to main menu - hide CLA text for corp and GH users - add link back to cla-assistant on success
- add tests - other cleanup per code review
- add tests - other cleanup per code review - support the "employer asserts no rights" round trip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-_____
ALLOW_MANY_COMMITS=true