Add arm ite blocks samples from #853 #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merged, thanks! |
|
I’m afraid that test isn’t properly maintained for a long time. And samples are not designed for testing purpose.
…________________________________
From: crass ***@***.***>
Sent: Thursday, August 19, 2021 11:12:10 AM
To: unicorn-engine/unicorn ***@***.***>
Cc: lazymio ***@***.***>; Author ***@***.***>
Subject: Re: [unicorn-engine/unicorn] Add arm ite blocks samples from #853 (#1381)
This is causing the make test to fail.
cd .. && python const_generator.py python
make[2]: Leaving directory '/home/ubuntu-budgie/unicorn.git/bindings/python'
LD_PRELOAD=librt.so LD_LIBRARY_PATH=../ DYLD_LIBRARY_PATH=../ ../samples/sample_
arm > sample_arm.c.txt
LD_PRELOAD=librt.so LD_LIBRARY_PATH=../ DYLD_LIBRARY_PATH=../ python python/samp
le_arm.py > sample_arm.py.txt
diff -u sample_arm.c.txt sample_arm.py.txt
--- sample_arm.c.txt 2021-08-19 03:04:24.443138456 +0000
+++ sample_arm.py.txt 2021-08-19 03:04:24.587139604 +0000
@@ -10,13 +10,3 @@
>> Tracing instruction at 0x10000, instruction size = 0x2
>> Emulation done. Below is the CPU context
>> SP = 0x1228
-==========================
-Emulate a THUMB ITE block as a whole or per instruction.
-Running the entire binary.
->>> R2: 104
->>> R3: 1
-
-Running the binary one instruction at a time.
->>> R2: 104
->>> R3: 1
-
make[1]: *** [Makefile:46: sample_arm.py.test] Error 1
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1381 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULO6ALXBDJDYRK7GX55DT5RZAVANCNFSM42A6OVVQ>.
|
|
I deleted my previous comment before I had seen your reply because I realized that the problem wasn't this commit but a previous one. However, if samples aren't designed for testing purposes, then why are they included in |
|
As explained just now, the ‘make test’ is not maintained (the tests are really a big mess, see tests/ directory for details). It shall work in uc2. Link to #1217.
…________________________________
From: crass ***@***.***>
Sent: Thursday, August 19, 2021 11:21:37 AM
To: unicorn-engine/unicorn ***@***.***>
Cc: lazymio ***@***.***>; Author ***@***.***>
Subject: Re: [unicorn-engine/unicorn] Add arm ite blocks samples from #853 (#1381)
I deleted my previous comment before I had seen your reply because I realized that the problem wasn't this commit but a previous one. However, if samples aren't designed for testing purposes, then why are they included in make test?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1381 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULOZ2BHNGVGG4QTKY4BLT5R2EDANCNFSM42A6OVVQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the sample from #853 to sample-arm.c.