Fix big endian issues #1710
Fix big endian issues #1710
Conversation
The endianness of the guest leaks to the host if memory is read. This needs to be dealt with if the host endianness differs from the guest endianness.
|
After applying this PR, these two checks will continue to fail on BE hosts, and I am not entirely sure what the problem is. I disabled these two checks in Debian for now, but I hope someone can come up with an actual fix. |
|
I failed to understand the context here, anyway I can reproduce this? |
|
The test failures happen if you run UC on a host with big endian architecture, such as PowerPC, S390X, etc. |
| @@ -4,6 +4,7 @@ | |||
| #include <stdio.h> | |||
| #include <stdint.h> | |||
| #include <unicorn/unicorn.h> | |||
| #include "qemu/bswap.h" | |||
There was a problem hiding this comment.
This is wrong since we don't import qemu things in test files as they are not linked against the test targets, though it may work...
| @@ -1603,7 +1603,7 @@ static void gen_xxspltw(DisasContext *ctx) | |||
| tofs = vsr_full_offset(rt); | |||
| bofs = vsr_full_offset(rb); | |||
| bofs += uim << MO_32; | |||
| #ifndef HOST_WORDS_BIG_ENDIAN | |||
| #ifndef HOST_WORDS_BIGENDIAN | |||
| #endif | ||
| } | ||
|
|
||
| uc->set_pc(uc, begin); |
There was a problem hiding this comment.
These two functions are not exactly the same unfortunately. You have to add:
// force to quit execution and flush TB
uc->quit_request = true;
uc_emu_stop(uc);| @@ -164,9 +164,9 @@ static void test_arm_thumb_ite(void) | |||
| OK(uc_reg_write(uc, UC_ARM_REG_R3, &r_r3)); | |||
|
|
|||
| OK(uc_mem_map(uc, r_sp, 0x1000, UC_PROT_ALL)); | |||
| r_r2 = 0x68; | |||
| r_r2 = cpu_to_le32(0x68); | |||
There was a problem hiding this comment.
A good way I think is to detect the host endianness directly and do this like:
#ifdef BIG_ENDIAN
r_r2 = bswap32(0x68)
#else
r_r2 = 0x68
#endif
| @@ -172,8 +172,11 @@ static void test_x86_inc_dec_pxor(void) | |||
|
|
|||
| TEST_CHECK(r_ecx == 0x1235); | |||
| TEST_CHECK(r_edx == 0x788f); | |||
| #ifndef HOST_WORDS_BIGENDIAN | |||
There was a problem hiding this comment.
Note again we don't use QEMU defines in the test files.
|
Fixed as of a40bf26 |
This PR fixes a few test failures if the host architecture is Big Endian:
uc_emu_startwill end up zeroed. Luckily, the existingset_pcfunction handles all corner cases correctly.cpu_to_leandle_to_cpufunctions (which are no-ops on LE hosts) for this.