Skip to content

add RequestReviewAction as SKStoreReviewController is deprecated #20670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anderbr4
Copy link

@Anderbr4 Anderbr4 commented Jun 1, 2025

GitHub Issue: closes #18902

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

This issue: #18902
One of the maintainers of the code: https://github.com/MartinZikmund wants the use of SKStoreReviewController replaced with RequestReviewAction in the following file: StoreContext.UIKits.cs.

The reason this is important is that the SKStoreReviewController is deprecated and I found more information on that switch in this stackoverflow post: https://stackoverflow.com/questions/79022583/ios-skstorereviewcontroller-is-deprecated-how-to-use-requestreviewaction-on-pr

What is the new behavior?

RequestReviewAction in the following file: StoreContext.UIKits.cs will ensure no issues when SKStoreReviewController is no longer functional.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

N/A

Internal Issue (If applicable):
This issue: #18902

@github-actions github-actions bot added the platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform label Jun 1, 2025
@Anderbr4
Copy link
Author

Anderbr4 commented Jun 1, 2025

Summary of the changes (Less than 80 chars)

Addresses #18902

@unodevops
Copy link
Contributor

⚠️⚠️ The build 167367 has failed on Uno.UI - docs.

@unodevops
Copy link
Contributor

⚠️⚠️ The build 167368 has failed on Uno.UI - CI.

@spouliot
Copy link
Contributor

spouliot commented Jun 1, 2025

@Anderbr4 thanks 😄 but there's a small problem here. The new API is only available in iOS 16 but Uno supports older versions of iOS.

There are two choices in order not to break apps running on older iOS versions

  1. use the older deprecated API until the minimum version of iOS supported by Uno is at least 16.0 (that's what the existing code does right now)

  2. use a version check at runtime and call the new API if running in 16+ or fallback to the older API

@jeromelaban jeromelaban requested review from MartinZikmund and Copilot and removed request for MartinZikmund June 2, 2025 12:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the deprecation of SKStoreReviewController by replacing it with RequestReviewAction to ensure continued functionality of the app's store review feature.

  • Replaces SKStoreReviewController.RequestReview with RequestReviewAction.RequestReview in StoreContext.UIKit.cs
  • Ensures the app remains compatible with upcoming iOS versions following the deprecation
Comments suppressed due to low confidence (1)

src/Uno.UWP/Services/Store/StoreContext.UIKit.cs:73

  • Verify that RequestReviewAction.RequestReview provides behavior consistent with expectations across all targeted iOS versions.
RequestReviewAction.RequestReview(UIApplication.SharedApplication.KeyWindow.WindowScene);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Use RequestReviewAction in favor of SKStoreReviewController
3 participants