Skip to content

Migrate to golang-jwt with replace in go.mod #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

turkenh
Copy link
Member

@turkenh turkenh commented Jul 27, 2021

Description of your changes

Migrate to golang-jwt v3.2.1 as advised in the description of the security issue CVE-2020-26160.

Different than #166, this PR follows the steps in the migration guide of https://github.com/golang-jwt/jwt and uses replace directive to replace all direct and indirect dependencies to the problematic library.

This, however, fails with go mod tidy

15:21:50 [ .. ] go mod tidy
go: finding module for package github.com/golang-jwt/jwt/request
go: finding module for package github.com/golang-jwt/jwt/test
go: finding module for package github.com/golang-jwt/jwt
go: downloading github.com/golang-jwt/jwt v1.0.2
go: found github.com/golang-jwt/jwt in github.com/golang-jwt/jwt v3.2.1+incompatible
go: found github.com/golang-jwt/jwt/request in github.com/golang-jwt/jwt v3.2.1+incompatible
go: found github.com/golang-jwt/jwt/test in github.com/golang-jwt/jwt v3.2.1+incompatible
go: github.com/golang-jwt/[email protected]+incompatible used for two different module paths (github.com/dgrijalva/jwt-go and github.com/golang-jwt/jwt)
15:21:52 [FAIL]

Fixes GHSA-w73w-5m7g-f7qc

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make e2e.run and verify that validation passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant