Gx 19315 ✅ tools qa elements broken links images #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… se crea POM, resultado esperado
…o GX-19315-✅-tools-qa-elements-broken-links-images
LauraMont
reviewed
Jun 5, 2023
There was a problem hiding this comment.
Hola Cecilia ,te comento la review:
- El uso de POM es correcto
- Las validaciones también están muy bien en cada TC, interesante la de title para link valido
- Para mejora te recomiendo renombrar para que se entienda mejor la variable que te traes del POM, puedes hacerlo de la siguiente forma:
import { broken as link } from '@pages/Elements/GX-19315-Broken.Page'Otra recomendación que es realmente por preferencia mía es utilizar el get en vez de elements dentro del POM, al utilizarlo se entiende mejor que estamos obteniendo
Queda aprobado, Excelente trabajo!
AlexanderWindecker
deleted the
GX-19315-✅-tools-qa-elements-broken-links-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimada, entrego US con las siguientes modificaciones: