Gx 23722 ✅ tools qa elements broken links images #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LauraMont
added
In Review
LauraMont
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Hola Pablo! Comenzamos la review con algunos topics que suelo evaluar:
- US Jira: En general se ve bien
- Cobertura de pruebas: Esta completa, como no hay mucha complejidad en la funcionalidad es sencillo de realizar
- POM: Muy bien implementada la estructura.
- Código: Esta correcto en general, muy bueno lo del intercept. Te hice un comentario sobre una mejora pero esta bien como ya lo has hecho. Si tengo algunos mas sobre el código te los dejo mas abajo
Buen trabajo Pablo! Voy cerrando esta US en Jira
LauraMont
reviewed
Jul 13, 2023
| cy.visit('/broken'); | ||
| }); | ||
|
|
||
| it('GX-23722 | TC1: Validar las propiedades de imagen valida', () => { |
There was a problem hiding this comment.
No olvides que los títulos solo tienen al comienzo el numero del summary ,es decir, sin el 'GX-'
LauraMont
reviewed
Jul 13, 2023
| @@ -0,0 +1,35 @@ | |||
| import { removeLogs } from '@helper/RemoveLogs'; | |||
| import { brokenL } from '@pages/Elements/GX-23722-BrokenLinks'; | |||
| import data from '@data/GX-23722-BrokenLink.json'; | |||
There was a problem hiding this comment.
Muy bien el uso de la ruta para data
LauraMont
reviewed
Jul 13, 2023
| get={ | ||
| ValidImage: ()=> cy.get('[class^="col-12"] [src$="/Toolsqa.jpg"]'), | ||
| BrokedImage: ()=> cy.get('[src$="/Toolsqa_1.jpg"]'), | ||
| AllLinks: numberLink => cy.get('[class^="col-12"] a').eq(`${numberLink}`) |
There was a problem hiding this comment.
aquí con la data podrías aprovechar el Link, similar como lo implementaste pero obtenerlo directamente con la propiedad href ya que esta es la que contiene el link a la pagina
LauraMont
added
Approved
ZwitterKaneda
removed
the
Code Review Feedback
AlexanderWindecker
deleted the
GX-23722-✅-tools-qa-elements-broken-links-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se realizaron 4 TC y todos pasaron las pruebas se aplico POM y Fixture.
Solo hubo algunos detalles con Xray , la Gestión de las pruebas fue realizada en Qmetry.