Skip to content

GX-23814 Todos los TC Pasaron ok #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

natipedraza22
Copy link

Todos los TC pasaron correctamente.

@natipedraza22 natipedraza22 added Needs Review Ready for review by the team. Tutor Assigned I have a tutor assigned labels Jul 12, 2023
@natipedraza22 natipedraza22 self-assigned this Jul 12, 2023
@ZwitterKaneda ZwitterKaneda added In Review Currently being evaluated by the reviewer. and removed Needs Review Ready for review by the team. labels Jul 16, 2023
@ZwitterKaneda
Copy link
Contributor

ZwitterKaneda commented Jul 16, 2023

Los haré trabajar 😅 en este pull request te faltó agregar tu documentación @natipedraza22 recuerda que en la carpeta cypress/test-plan/in-sprint/sprint-21/*.md irá tu archivo con la documentación que tienes en Jira.

Es algo sensillo para hacer =) quiero que practiques con GIT. Espero el cambio

EDIT: Olvidaba, tienes que hacer fetch de la rama QA para actualizarla. Los pasos serán:
git checkout GX-23814-✅-tools-qa-elements-buttons
git fetch origin QA
git merge origin/QA
Aquí debería de tener un conflicto con tu archivo CI-Suite.yml ya que te llevarás el que esta en QA y el tuyo tiene otro cambio, debes de aceptar tu cambio.

@ZwitterKaneda ZwitterKaneda added Minor Tweaks Needed Requires minor adjustments before merging. and removed In Review Currently being evaluated by the reviewer. labels Jul 16, 2023
@ZwitterKaneda ZwitterKaneda added Approved Approved and pending merge. and removed Minor Tweaks Needed Requires minor adjustments before merging. labels Jul 17, 2023
@ZwitterKaneda
Copy link
Contributor

Buen trabajo @natipedraza22 !! continuemos!

@ZwitterKaneda ZwitterKaneda merged commit 0217919 into QA Jul 17, 2023
@AlexanderWindecker AlexanderWindecker deleted the GX-23814-✅-tools-qa-elements-buttons branch August 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and pending merge. Tutor Assigned I have a tutor assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants