Gx 22176 ✅ tools qa elements buttons #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entacion, se integro CI
LauraMont
added
In Review
LauraMont
reviewed
Jul 23, 2023
There was a problem hiding this comment.
Hola Karina! Te comento algunos puntos a tener en cuenta en esta review:
- US en Jira: Muy bien cerrados TS y TX .Te falto transicionar la US a Test Passed (este en caso de que todas las pruebas pasaron), cerrar el task y la trazabilidad de los TC. No olvides que este flujo es el mismo que con manual
- Código: Vas genial por aca ,la nomenclatura y los TC están correctamente ejecutados
- Otros: Bien agregado el markdown (.md) en la carpeta correspondiente, el CI también fue editado correctamente
- Mejoras: Te recomiendo que sigas al menos un par de US para dominar la sintaxis de los TC y el flujo para luego seguir con fixture
Por aca terminamos ,este PR queda aprobado. Quedo al pendiente de la corrección en la US que es lo único que faltaría.
Buen trabajo Karina!
LauraMont
added
Minor Tweaks Needed
|
Se verificaron los cambios en la US de Jira, esta US esta para mergear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se realizaron todas las pruebas y se modificaron los archivos.