GX3-390 Se ha procedido a crear el md, los tests y se modificó el CI #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LauraMont
requested review from
LauraMont
and removed request for
ZwitterKaneda
LauraMont
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Hola Franco, nuestro amigo Dani esta de vacas asique te voy a echar una mirada en este PR
Te comento algunas cosas que nos van a interesar en esta review:
- US en Jira: Esta perfecto el flujo por aqui , estoy cerrando la US
- CI y doc: bien editado el ci y la carpeta del markdown
- Commits y PR: Excelente la estructura del PR y el commit
- Codigo: te comento debajo en las lineas que corresponda
Buen trabajo Franco, este PR queda aprobado!
PD: esta vez te resuelvo el conflicto en el PR pero las siguientes te lo dejo de tarea
LauraMont
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resumen de cambios
Se ha hecho un git pull origin QA dentro de QA para que el repo local quede con todo lo nuevo que estaba en el remoto, he creado la nueva rama y la misma quedo con todos estos cambios nuevos de QA, ya que al haber hecho primero el pull de QA, se conservó esta información hacia la nueva rama.
Resultados de las pruebas
Las pruebas han pasado exitosamente junto con las validaciones