GX3-1612: Tools Qa Elements Dynamic Properties #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZwitterKaneda
added
In Review
ZwitterKaneda
approved these changes
Jan 23, 2024
|
|
||
| it('GX3-1612 | TC2: Validate enabled element after 5 seconds', () => { | ||
| cy.get('#enableAfter').should('be.disabled'); | ||
| cy.wait(5000); |
There was a problem hiding this comment.
Hola Lilia, has realizado un buen trabajo en el test. Sin embargo, me gustaría hacerte una sugerencia en la parte donde utilizas cy.wait(5000). En lugar de eso, te recomendaría utilizar la opción timeout dentro de la función del get del elemento al que estás esperando. Esto se hace para que la espera sea "hasta" 5 segundos y no "durante" 5 segundos con el wait.
En lugar de:
cy.wait(5000)
Podrías utilizar:
cy.get('tuElemento', { timeout: 5000 })
Espero que esta sugerencia sea clara. Si tienes alguna pregunta o necesitas más ayuda, estoy aquí para ayudarte.
There was a problem hiding this comment.
Entiendo. Realizaré los cambios. Gracias
ZwitterKaneda
added
Approved
AlexanderWindecker
deleted the
GX3-1612-tools-qa-elements-dynamic-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Changes
Test Results
Observations