Migrate tests to native test runner #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `jest` with `node:test`. - Update minimum Node.js version to `v22.14.0` and `v23.4.0`. - Adds `tests` GitHub Action.
There was a problem hiding this comment.
Pull Request Overview
Migrates the project’s tests from Jest to Node’s built-in test runner, updates Node version requirements, and adds a GitHub Actions workflow for testing.
- Replace Jest with
node:test, update test scripts, and move snapshots to*.snapshotalongside test files - Bump minimum Node.js engine to v22.14.0 (or ≥23.4.0) and update
.nvmrc - Add CI matrix in GitHub Actions for Node v22 and v24
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/rules.test.js | Converted from Jest to node:test, updated linter setup and assertions |
| test/rules.test.js.snapshot | Added inline snapshot for node:test snapshot matching |
| test/fixtures/correct.js | Updated “correct” fixture for React hooks and class component |
| test/fixtures/incorrect.js | Updated “incorrect” fixture to trigger ESLint rule violations |
| test/snapshots/rules.test.js.snap | Removed outdated Jest snapshot |
| package.json | Updated test scripts, removed Jest dependency, and bumped Node engine |
| .nvmrc | Changed Node version from v18.11.0 to v22.14.0 |
| .github/workflows/tests.yaml | Added CI workflow to run tests on Node v22 and v24 |
| README.md | Added badges and standardized install/test snippets |
Comments suppressed due to low confidence (1)
test/fixtures/correct.js:32
- The
correct.jsfixture now returns JSX ingetFoo, which will trigger thereact/prefer-stateless-functionrule. It should be reverted to return a non-JSX value (e.g., a string) to ensure zero violations.
getFoo = () => <div>Hello</div>;
| @@ -31,6 +34,6 @@ describe('eslint-config-uphold-react', () => { | |||
| severity | |||
| })); | |||
|
|
|||
| expect(violations).toMatchSnapshot(); | |||
| test.assert.snapshot(violations); | |||
There was a problem hiding this comment.
The node:test API does not provide test.assert.snapshot. Use the correct snapshot assertion method (e.g., test.snapshot(violations) or test.assert.matchSnapshot(violations)), otherwise this will throw.
Suggested change
| test.assert.snapshot(violations); | |
| test.assert.matchSnapshot(violations); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jestwithnode:test.v22.14.0andv23.4.0.testsGitHub Action testing v22 and v24.