-
Notifications
You must be signed in to change notification settings - Fork 455
Improve Solidity ABI support in codegen
, ink_env
and ink_e2e
#2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidsemakula
wants to merge
29
commits into
master
Choose a base branch
from
semakula/sol-abi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8844bb0
to
77fd36b
Compare
codegen
, ink_env
and ink_e2e
9639e88
to
59b4e11
Compare
… and `examples-docs` jobs
1828938
to
bb10c64
Compare
bb10c64
to
7691e9e
Compare
7691e9e
to
8a7d7ee
Compare
e351401
to
82c595d
Compare
82c595d
to
ea17ad7
Compare
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the Show Results
Link to the run | Last update: Thu Jun 19 01:16:22 CEST 2025 |
95f80a0
to
d67a9a0
Compare
d67a9a0
to
d80d0ba
Compare
…d at compile time
3c2174a
to
5513bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #_
cargo-contract
orpallet-revive
?Description
codegen
to properly support Solidity ABI (i.e. generate trait info for Solidity selectors, and update related generated message builders, call builders and call forwarders)ink::contract_ref!
andink::message_builder!
) to support ABI parametersAbi
for the generic type param and enum, andInk
andSol
for the marker types)ink::codegen::DispatchInputSol
andink::codegen::DispatchOutputSol
docs)ink_env::build_call_abi<Environment, Abi>
,ink_e2e::call_builder_abi<Contract, Abi>
andink_e2e::InstantiationResult::call_builder_abi<Contract, Abi>
utilitiesink_e2e
to support Solidity ABI encoded message calls (i.e.CallDryRunResult::message_result
andCallDryRunResult::return_value
)__ink_generate_metadata
) for Solidity ABI only contractsChecklist before requesting a review
CHANGELOG.md