Some stats page issues.

[solarissmoke]

• If there is a connection problem when trying to create a site on the
  stats server, a fatal error occurs.
• The stats tab shouldn't be visible if stats are disabled?

[rjmackay]

Theres some confusion here: the allow_stat_sharing setting includes some JS on the page to hit the Ushahidi stats tracker. These stats can later be view through that stats admin.

However the stats admin also shows other stats on categories etc. Which I don't think need the stats JS (correct me if you think I'm wrong.. haven't read that code recently). So we shouldn't hide the stats tab completely. Just the stats that aren't being collected.

The 2nd change to avoid the fatal error is good though. But can you drop the stats tab change?

[solarissmoke]

@rjmackay my mistake. Have reverted the stats tab changes leaving only the error checking in create_site().

[rjmackay]

I've merge this in but reworded your commit message to describe what actually changed: eaf1a69

[solarissmoke]

Thanks. I tried to be clever with reverting but it just overwrote my original commit.

[rjmackay]

git rebase -i is great for cleaning up pull requests. Lets you squash commits together or reword the messages, etc.