Stop checking what characters are in passwords, refs #1371, fixes #1372 #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can base it on this #285 |
|
I'm not sure what you mean by suggesting that it is related to #258...? |
|
Updated description to clarify the intent in reference to #285. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#285 changed password validation from
alpha_numerictoalpha_dashto solve a problem with the validation message, but (functionally) all this did was add the characters_-to the allowed list, which still prevents special characters from being used.As noted by @rjmackay on #285, the real goal is to allow any characters to be used for passwords. (This is shown by #1371.) Right now, only letters, numbers, dash, and underscore can be used, but the restriction is arbitrary, as the end result is that all passwords are hashed, making the character set irrelevant.