shred: remove usage of Vec::set_len() #1738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes usage of
Vec::set_len()
(#1729). It also avoids allocating a newVec
every timeBytesGenerator
iterates, so it is most likely actually faster than before. Note that there is still quite a bit of room for improvement in terms of performance(e.g. copying entire patterns rather than pushing them to theand readability.Vec
one byte at a time)There is at least one more instance of
Vec::set_len()
that needs to be fixed (it's inod
again). We may want to simply review our usage ofunsafe
in general, as I imagine some of the cruft that's built up over the years can be removed.