Fixes Negative numbers for @ not being recognized #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philolo1
force-pushed
the
fix/40-timestamp
branch
from
9db328c to
d3383c7
Compare
philolo1
force-pushed
the
fix/40-timestamp
branch
from
9071053 to
cbfc1cf
Compare
|
@tertsdiepraam adjusted the code. |
philolo1
force-pushed
the
fix/40-timestamp
branch
from
cbfc1cf to
57f871e
Compare
sylvestre
reviewed
Sep 1, 2023
src/parse_timestamp.rs
Outdated
| use nom::sequence::tuple; | ||
| use nom::{self, IResult}; | ||
|
|
||
| pub(crate) fn parse_timestamp(s: &str) -> Option<i64> { |
There was a problem hiding this comment.
can we return:
Result<i64, ParseTimestampError>
like we return ParseDateTimeError elsewhere?
sylvestre
reviewed
Sep 1, 2023
src/parse_timestamp.rs
Outdated
| let res: IResult<&str, (char, &str)> = all_consuming(preceded( | ||
| char('@'), | ||
| tuple(( | ||
| // Note: gnu date allows multiple + and - and only considers the last one |
There was a problem hiding this comment.
maybe add that we are doing the same
sylvestre
reviewed
Sep 1, 2023
| @@ -0,0 +1,67 @@ | |||
| use nom::branch::alt; | |||
There was a problem hiding this comment.
please add the license header
sylvestre
reviewed
Sep 1, 2023
src/lib.rs
Outdated
| return Ok(dt); | ||
| } | ||
| if let Some(timestamp) = parse_timestamp(s.as_ref()) { | ||
| let timestamp_date = NaiveDateTime::from_timestamp_opt(timestamp, 0).unwrap(); |
There was a problem hiding this comment.
what happens in case of error ?
This commit resolves uutils#40. Adds new file and functions parse_timestamp. Adds tests for handling negative numbers.
philolo1
force-pushed
the
fix/40-timestamp
branch
from
57f871e to
b150932
Compare
|
@sylvestre updated, let me know if you like to resolve the comments, or i should. I am not sure how you handle it. |
|
@tertsdiepraam @sylvestre just checking on the status. I think someone needs to review it. |
sylvestre
reviewed
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves #40.
Adds new file and functions parse_timestamp.
Adds tests for handling negative numbers.
@tertsdiepraam @sylvestre