Skip to content

epoch timezone fix #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2024
Merged

epoch timezone fix #67

merged 1 commit into from
Mar 24, 2024

Conversation

matrixhead
Copy link
Contributor

fix for #66

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.71%. Comparing base (249c079) to head (deffff9).
Report is 1 commits behind head on main.

Files Patch % Lines
src/lib.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   68.30%   68.71%   +0.41%     
==========================================
  Files           6        6              
  Lines         795      812      +17     
  Branches      188      195       +7     
==========================================
+ Hits          543      558      +15     
- Misses        130      137       +7     
+ Partials      122      117       -5     
Flag Coverage Δ
macos_latest 68.71% <84.61%> (+0.41%) ⬆️
ubuntu_latest ?
windows_latest 7.44% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Contributor

could you please add a test showing that the previous behavior isn't happening anymore? thanks

@matrixhead
Copy link
Contributor Author

matrixhead commented Mar 4, 2024

done 👍 i've added a test case for this but i couldn't figure out why the checks are failing
edit: fixed it. It was a problem with my previous commit

@cakebaker cakebaker linked an issue Mar 4, 2024 that may be closed by this pull request
@sylvestre sylvestre requested a review from tertsdiepraam March 24, 2024 16:10
@tertsdiepraam tertsdiepraam merged commit ff2113e into uutils:main Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epoch parsing with timezone other than UTC
3 participants