Skip to content

Use appropiately qualified names in blas and rng #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2021

Conversation

sbalint98
Copy link
Contributor

Description

Some types in the blas and rng domain did not have properly qualified names. This has caused trouble when using different SYCL implementations. This PR fixes this for these two domains.

related to #99

All Submissions

  • Do all unit tests pass locally? Attach a log.
  • Have you formatted the code using clang-format?

Copy link
Contributor

@mkrainiuk mkrainiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR! I have one comment regarding these changes.

@mmeterel mmeterel requested a review from aelizaro August 12, 2021 18:08
@mmeterel
Copy link
Contributor

@sbalint98 Could you please resolve the conflicts?

@sbalint98 sbalint98 force-pushed the ustream-qualifications branch from 64e6fa2 to b0c8511 Compare August 15, 2021 23:55
@mmeterel mmeterel merged commit c8c0d8f into uxlfoundation:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants