Skip to content

delete and log function #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

gdavila09
Copy link

@gdavila09 gdavila09 commented Dec 18, 2018

Description

delete function available in audit
Fixes # TEAPP-23

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gdavila09 gdavila09 force-pushed the gdavila/TEAPP-23-delete-and-log branch 2 times, most recently from c929282 to ae007f4 Compare December 19, 2018 00:39
multi
|> Multi.run(:changelog, &log_changes(repo, &1, struct_or_changeset, actor_id))
|> Multi.run(:changelog, &log_changes(repo, &1, struct_or_changeset, actor_id, type_operation))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operation_type

@@ -166,6 +201,37 @@ defmodule EctoTrail do
end
end

defp validate_changes(changes, schema, operation_type) do
case operation_type do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agrega comentarios de que es cada operatio type:
ej

1 -> # insert

@gdavila09 gdavila09 force-pushed the gdavila/TEAPP-23-delete-and-log branch from ae007f4 to bade652 Compare December 19, 2018 10:25
@acrogenesis acrogenesis merged commit b1abcc1 into master Dec 19, 2018
@acrogenesis acrogenesis deleted the gdavila/TEAPP-23-delete-and-log branch December 19, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants