fix issue when ignoring destroy_cloud_config_vdi_after_boot #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gCyrille
force-pushed
the
fix/issue-338-ignoring-destroy_cloud_config_vdi_after_boot
branch
from
e5818f9 to
c1375f4
Compare
gCyrille
deleted the
fix/issue-338-ignoring-destroy_cloud_config_vdi_after_boot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #338
When destroy_cloud_config_vdi_after_boot is set to true, it requires the set the power_state to "Running" even if the power_state changes are ignored in resource lifecycle (for example when the cm is stopped).
With this PR, when destroy_cloud_config_vdi_after_boot=true it will check if power_state is "Running" only if it has changed