-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(external): introduce log namespace guide #22938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise 👍
Created this docs card for editorial review: https://datadoghq.atlassian.net/browse/DOCS-10696 |
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one unclear sentence I'd recommend revising. Feel free to ping me again for a quick approval when ready!
Co-authored-by: Joe Peeples <[email protected]>
Nit: it would have been useful to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, otherwise 👍 This seems like a useful guide!
I renamed the branch which immediately closed the PR. Let's continue here: #22985 |
Summary
I wrote a guide to demonstrate how log namespacing works.
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Notes
@vectordotdev/vector
to reach out to us regarding this PR.pre-push
hook, please see this template.cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)./scripts/check_changelog_fragments.sh
git merge origin master
andgit push
.Cargo.lock
), pleaserun
cargo vdev build licenses
to regenerate the license inventory and commit the changes (if any). More details here.References
Ref: #22928