Skip to content

docs(external): introduce log namespace guide #22938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

pront
Copy link
Member

@pront pront commented Apr 23, 2025

Summary

I wrote a guide to demonstrate how log namespacing works.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • The CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
      • ./scripts/check_changelog_fragments.sh
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

References

Ref: #22928

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Apr 23, 2025
@pront pront requested a review from jszwedko April 23, 2025 18:19
@pront pront requested a review from a team as a code owner April 23, 2025 18:19
@pront pront requested a review from bfung April 23, 2025 18:19
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise 👍

@maycmlee maycmlee self-assigned this Apr 23, 2025
@maycmlee
Copy link
Contributor

Created this docs card for editorial review: https://datadoghq.atlassian.net/browse/DOCS-10696

@maycmlee maycmlee removed their assignment Apr 23, 2025
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Apr 23, 2025

Datadog Report

Branch report: pront/log-namespace-guide
Commit report: e06cd01
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time

@pront pront changed the title feat(website): introduce log namespace guide docs(external): introduce log namespace guide Apr 29, 2025
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, otherwise 👍

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one unclear sentence I'd recommend revising. Feel free to ping me again for a quick approval when ready!

@pront pront requested review from joepeeples and jszwedko May 1, 2025 17:58
@jszwedko
Copy link
Member

jszwedko commented May 1, 2025

Nit: it would have been useful to include website in the branch name to get a preview deploy 🙂

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments, otherwise 👍 This seems like a useful guide!

@pront pront closed this May 1, 2025
@pront pront deleted the pront/log-namespace-guide branch May 1, 2025 18:44
@pront
Copy link
Member Author

pront commented May 1, 2025

Nit: it would have been useful to include website in the branch name to get a preview deploy 🙂

I renamed the branch which immediately closed the PR. Let's continue here: #22985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants