-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(platforms): Migrate x86 gnu target to cross, add new aarch64 gnu target (no sasl) #3657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Related to #3537 |
Signed-off-by: Ana Hobden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great so far! I can actually understand it.
I was surprised that the artifact appears to be dynamically linked though:
➜ vector2 git:(cross-targets) ✗ file target/x86_64-unknown-linux-gnu/release/vector
target/x86_64-unknown-linux-gnu/release/vector: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=61bb011dd509137d895c193d0915cafedbafdade, not stripped
➜ vector2 git:(cross-targets) ✗ ldd target/x86_64-unknown-linux-gnu/release/vector
linux-vdso.so.1 (0x00007ffd81746000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fd8635da000)
libresolv.so.2 => /lib64/libresolv.so.2 (0x00007fd8633c4000)
libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007fd863042000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007fd862e3e000)
librt.so.1 => /lib64/librt.so.1 (0x00007fd862c36000)
libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fd862a20000)
libc.so.6 => /lib64/libc.so.6 (0x00007fd862675000)
/lib64/ld-linux-x86-64.so.2 (0x00007fd866035000)
libm.so.6 => /lib64/libm.so.6 (0x00007fd862335000)
Is that expected?
I'm trying the aarch64 build now.
${EMPTY} | ||
|
||
# This is basically a shorthand for folks. | ||
# `cross-anything-triple` will call `cross anything --target triple` with the right features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
--no-default-features \ | ||
--features target-${TRIPLE} | ||
|
||
target/%/vector: export PAIR =$(subst /, ,$(@:target/%/vector=%)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL you can set target specific variables like this 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also do ?=
to only set if not set, and override
to force a specific variable to be set. One note though, the envs you export here you can't use in the target dependencies below. :(
Noting that from the call we expect glibc to be dynamically linked. It isn't clear if the rest of the above ones fall in that bucket or not. These are the linked libraries I see for aarch64:
Are these the expected ones? |
@jszwedko I'm noting this: Hm, I wonder how much we value centos:7 support? |
@jszwedko This seems expected: |
Signed-off-by: Ana Hobden <[email protected]>
Hmm. I feel like it'd be nice to given that
All of which seemed fine. This seems like something we might want to have a build matrix to verify supported OSes for. |
No problem, I think we have this https://github.com/timberio/vector/blob/cross-env/scripts/environment/bootstrap/centos-7.sh I can use. |
We decided not to use a custom image since we identified cross-rs/cross#455 |
Signed-off-by: Ana Hobden <[email protected]>
I'm going to explore re-enabling sasl a bit before I prep a musl PR. |
Signed-off-by: Ana Hobden <[email protected]>
No dice. I'm going to base a new musl PR off this, but this is ready for review. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I like how this is coming together.
Just one note about the CI target for the build-aarch64-unknown-linux-gnu
action that should be resolved, otherwise 👍
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
@jszwedko The final feedback is reflected. :) I'm going to move onto the musl builds and try to get them going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note this disables sasl2 support on GNU AARCH builds for now. I'd still like to fix this. |
Trying with
With
|
commit 2b08b6d Author: Nell Shamrell-Harrington <[email protected]> Date: Sun Sep 13 23:10:18 2020 -0700 docs: Updates reference to gitter to point to the Discord server (#3858) Signed-off-by: Nell Shamrell <[email protected]> commit 27ba8b9 Author: James Turnbull <[email protected]> Date: Sat Sep 12 17:26:13 2020 -0400 chore: Removing CI references to Nix (#3844) Signed-off-by: James Turnbull <[email protected]> commit 7c95aa9 Author: James Turnbull <[email protected]> Date: Sat Sep 12 17:25:54 2020 -0400 chore: Fix make prepare-environment (#3841) commit cc00cf0 Author: James Turnbull <[email protected]> Date: Sat Sep 12 13:38:39 2020 -0400 chore: Added workflow_dispatch for the env workflow (#3842) commit b7f656e Author: James Turnbull <[email protected]> Date: Sat Sep 12 12:14:21 2020 -0400 chore: Fix Debian post-install process to reload systemd daemons (#3832) commit c2078b7 Author: binarylogic <[email protected]> Date: Sat Sep 12 10:28:41 2020 -0400 chore: Remove check-code.sh since it is no longer used Signed-off-by: binarylogic <[email protected]> commit 7887d4e Author: James Turnbull <[email protected]> Date: Fri Sep 11 23:50:56 2020 -0400 chore: Added cross installation to fix nightly builds (#3831) commit 648e82c Author: Ana Hobden <[email protected]> Date: Fri Sep 11 17:33:29 2020 -0700 chore(platforms): Migrate x86 gnu target to cross, add new aarch64 gnu target (no sasl) (#3657) * Add initial cross adoption Signed-off-by: Ana Hobden <[email protected]> * Add archiving Signed-off-by: Ana Hobden <[email protected]> * Clean up the makefile a bit and get tarballs working Signed-off-by: Ana Hobden <[email protected]> * checkpoint Signed-off-by: Ana Hobden <[email protected]> * wip Signed-off-by: Ana Hobden <[email protected]> * Add to CI Signed-off-by: Ana Hobden <[email protected]> * Add autoinstall to CI Signed-off-by: Ana Hobden <[email protected]> * Remove cruft Signed-off-by: Ana Hobden <[email protected]> * Can't test yet Signed-off-by: Ana Hobden <[email protected]> * Autoinstall in e2e Signed-off-by: Ana Hobden <[email protected]> * Readd docker image Signed-off-by: Ana Hobden <[email protected]> * More comments Signed-off-by: Ana Hobden <[email protected]> * Set right CI task Signed-off-by: Ana Hobden <[email protected]> * Add note about TZ issue Signed-off-by: Ana Hobden <[email protected]> commit b28eb18 Author: Bruce Guenter <[email protected]> Date: Fri Sep 11 16:22:58 2020 -0600 chore(networking): Rework internal auto concurrency tests (#3802) * Move auto concurrency test case data into TOML files * Use tokio manual time tracking to speed up tests By pausing and then manually advancing the clock, this provides for both very fast running tests and nearly perfect time measurements for highly repeatable test results. * Collect all the failures for each test This has the collateral benefit of being able to drop the large `assert_within` macro that was only used here. * The tests should now work predictably on MacOS Signed-off-by: Bruce Guenter <[email protected]> commit b37dea7 Author: Ana Hobden <[email protected]> Date: Fri Sep 11 14:53:14 2020 -0700 chore: Add some additional Event impls (#3621) * Move log_event to new file Signed-off-by: Ana Hobden <[email protected]> * Move value to new file Signed-off-by: Ana Hobden <[email protected]> * Move log_schema to config Signed-off-by: Ana Hobden <[email protected]> * chore: Add some event impls Signed-off-by: Ana Hobden <[email protected]> * Do some namespace squashing Signed-off-by: Ana Hobden <[email protected]> * Fixup lints Signed-off-by: Ana Hobden <[email protected]> * Remove From<Event> for Vec<u8> Signed-off-by: Ana Hobden <[email protected]> * Fixup leveldb Signed-off-by: Ana Hobden <[email protected]> * fmt Signed-off-by: Ana Hobden <[email protected]> * Jean's feedback Signed-off-by: Ana Hobden <[email protected]> commit f03898e Author: Luke Steensen <[email protected]> Date: Fri Sep 11 15:53:51 2020 -0500 enhancement(tokenizer transform): add internal events (#3807) Signed-off-by: Luke Steensen <[email protected]> commit ff555aa Author: Luke Steensen <[email protected]> Date: Fri Sep 11 15:53:27 2020 -0500 enhancement(dedupe transform): add internal events (#3809) Closes #3393 Signed-off-by: Luke Steensen <[email protected]> Co-authored-by: Jean Mertz <[email protected]> commit 54a4d8e Author: MOZGIII <[email protected]> Date: Fri Sep 11 17:09:57 2020 +0300 chore: Generate Kubernetes distribution YAMLs from Helm Chart (#3614) * Add a script to manage the Kubernetes YAML configs Signed-off-by: MOZGIII <[email protected]> * Update Helm Chart to generate config more like YAML files Signed-off-by: MOZGIII <[email protected]> * Switch to generated YAML Signed-off-by: MOZGIII <[email protected]> * Define check-all target in multiple lines Signed-off-by: MOZGIII <[email protected]> * Add Kubernetes YAML tasks to Makefile Signed-off-by: MOZGIII <[email protected]> * Add check-kubernetes-yaml to CI Signed-off-by: MOZGIII <[email protected]> * Add kubernetes-yaml.sh to .github/CODEOWNERS Signed-off-by: MOZGIII <[email protected]> * Add /scripts/kubernetes-yaml/ to .github/CODEOWNERS Signed-off-by: MOZGIII <[email protected]> * Add a TODO for passing the app-version Signed-off-by: MOZGIII <[email protected]> commit 68a5c43 Author: Do Duy <[email protected]> Date: Fri Sep 11 10:23:03 2020 +0700 docs: Add docs for retry_backoff_secs option (#3819) Signed-off-by: Duy Do <[email protected]> commit 1a1352b Author: James Turnbull <[email protected]> Date: Thu Sep 10 17:34:16 2020 -0400 chore: Remove docker-compose from integration tests (#3622) commit 94def0f Author: Luke Steensen <[email protected]> Date: Thu Sep 10 16:17:03 2020 -0500 enhancement(reduce transform): add internal events (#3812) Closes #3401 Signed-off-by: Luke Steensen <[email protected]> commit 74b43b7 Author: Bruce Guenter <[email protected]> Date: Thu Sep 10 14:05:52 2020 -0600 fix(networking): Rework auto concurrency backpressure logic (#3804) Previously, all responses were marked as not being backpressure. This changes that logic to: 1. Treat RetryAction::Retry responses as backpressure 2. Only use the RTT values from RetryAction::Successful responses Signed-off-by: Bruce Guenter <[email protected]> commit eb09b92 Author: Ana Hobden <[email protected]> Date: Thu Sep 10 13:01:23 2020 -0700 chore: Split up event (#3619) * Move log_event to new file Signed-off-by: Ana Hobden <[email protected]> * Move value to new file Signed-off-by: Ana Hobden <[email protected]> * Move log_schema to config Signed-off-by: Ana Hobden <[email protected]> * Do some namespace squashing Signed-off-by: Ana Hobden <[email protected]> * Fixup lints Signed-off-by: Ana Hobden <[email protected]> * Fixup leveldb Signed-off-by: Ana Hobden <[email protected]> * fmt Signed-off-by: Ana Hobden <[email protected]> commit 2fd9ccf Author: Jesse Szwedko <[email protected]> Date: Thu Sep 10 15:34:52 2020 -0400 chore: Add expected review counts to CONTRIBUTING.md (#3666) * chore: Add expected review counts to CONTRIBUTING.md Signed-off-by: Jesse Szwedko <[email protected]>
…u target (no sasl) (vectordotdev#3657) * Add initial cross adoption Signed-off-by: Ana Hobden <[email protected]> * Add archiving Signed-off-by: Ana Hobden <[email protected]> * Clean up the makefile a bit and get tarballs working Signed-off-by: Ana Hobden <[email protected]> * checkpoint Signed-off-by: Ana Hobden <[email protected]> * wip Signed-off-by: Ana Hobden <[email protected]> * Add to CI Signed-off-by: Ana Hobden <[email protected]> * Add autoinstall to CI Signed-off-by: Ana Hobden <[email protected]> * Remove cruft Signed-off-by: Ana Hobden <[email protected]> * Can't test yet Signed-off-by: Ana Hobden <[email protected]> * Autoinstall in e2e Signed-off-by: Ana Hobden <[email protected]> * Readd docker image Signed-off-by: Ana Hobden <[email protected]> * More comments Signed-off-by: Ana Hobden <[email protected]> * Set right CI task Signed-off-by: Ana Hobden <[email protected]> * Add note about TZ issue Signed-off-by: Ana Hobden <[email protected]> Signed-off-by: Brian Menges <[email protected]>
Builds a bit alongside the ideas of #3537.
Closes #3638.
Closes #3811.
Causes #3805.