chore(ci): Make tests for tracing-limit more robust #6632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a fake clock since the OSX Github Actions runner seems particularly noisy. I should have done this originally anyway for robustness and to not artificially bloat the test time. Signed-off-by: Jesse Szwedko <[email protected]>
jszwedko
requested review from
blt,
a team and
prognant
and removed request for
a team
jszwedko
commented
Mar 4, 2021
| } | ||
| }); | ||
|
|
||
| let events = events.lock().unwrap(); | ||
|
|
||
| dbg!(&events); |
jszwedko
commented
Mar 4, 2021
| @@ -15,6 +15,7 @@ dashmap = "4" | |||
| [dev-dependencies] | |||
| criterion = "0.3" | |||
| tracing = "0.1.15" | |||
| mock_instant = { version = "0.2" } | |||
There was a problem hiding this comment.
Seemingly not a very popular crate, but I took a look and it seems to do the trick and is fairly stable.
|
OSX failure still, but it is #5000 https://github.com/timberio/vector/pull/6632/checks?check_run_id=2035152311#step:8:1631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a fake clock since the OSX Github Actions runner seems particularly
noisy: #6614 (comment)
I should have done this originally anyway for robustness and to not
artificially bloat the test time.
Signed-off-by: Jesse Szwedko [email protected]