async/await support and other changes for meteor@3 #895

dr-dimitru · 2025-01-19T09:19:47Z

No description provided.

@Prinzhorn

📦 v2.2.0 __Breaking Changes__ - ⚠️ Changes in `namingFunction`, — now naming function acts the same on the Client and Server, upon insert, load, and write. Test your implementation with changed logic. Output of Server function supersedes Client's function output __Changes__ - 📔 Merge #843 and fix #820, thanks to @Prinzhorn - 📔 Documentation refactoring focused on examples and its simplifications - 👨‍💻 Support nested custom path returned from `namingFunction` - 👨‍💻 Fix `namingFunction` behavior on Client and Server in upload, load, and write methods, closing #842; Thanks to @chrschae - 👷‍♂️ Now library exports its helpers `import { FilesCollection, helpers };` - 👷‍♂️ Add `.meteorignore` to minimize package's footprint

@chrschae

📦 v2.2.1 - 👨‍💻 Fix #842, a newly detected bug by @chrschae; Fixing case when `namingFunction` returns new nested path cause exception in `.write()` and `.load()` methods

@xet7

📦 v2.3.0 __New features:__ - ✨ `opts.sanitize` method, read more in [*Constructor* docs](https://github.com/veliovgroup/Meteor-Files/blob/master/docs/constructor.md); Thanks to @xet7 and @mfilser __Other Changes:__ - 👷‍♂️ Minor codebase enhancements and cleanups

@Leekao

v2.3.1 __Changes:__ - 👨‍💻 Improve `createIndex` helper - 👨‍💻 Improve error output when FileSystem destination not writable; Related to #857, thanks to @Leekao - 🐞 Fix custom `allowedOrigins` option for CORS; Closing #850, thanks to @djlogan2; __Notes:__ - 👨‍🔬 Tested with latest release of `[email protected]`

📔 Improve AWS S3 documentation

📦 v2.3.2 - 👨‍💻 Potential fix for #857 (windows)

👷‍♂️ Update .eslintrc

@Gobliins

📦 v2.3.3 __Major changes:__ - no __Changes:__ - 👨‍🔧 Fixed #870, thanks to @Gobliins - 🤝 Compatibility with `[email protected]`

- Add `remainingTime` ReactiveVar to `FileUpload` instance with `hh:mm:ss` remaining upload time format

- Various fixes and improvements - Attempt to fix GitHub Actions

@mfeuermann

- Set `x_mtok` cookie to `secure` and `httpOnly`, thanks to @mfeuermann

dr-dimitru · 2025-03-26T22:06:40Z

@Friction-less-development thanks a lot for reporting this one, ostrio:[email protected] is out with fix for removeAsync included, please give it a try

- return `callback` argument back to `FileCursor#remove` method

dr-dimitru · 2025-03-27T22:45:09Z

@jankapunkt @bratelefant @harryadel @StorytellerCZ here's draft changelog for ostrio:[email protected], going to refactor and update docs now, please report issues if any.

Summary

✨ Refactor: Hook options: protected, onBeforeRemove, onAfterRemove, onInitiateUpload, onAfterUpload, namingFunction are now async
🤝 Refactor: Compatibility with meteor@3 and other modern packages
☄️ Refactor: Match FilesCollection APIs with new *Async methods of Mongo.Collection; Deprecate callback APIs on the Server
👨‍💻 Refactor: Utilize node's async APIs where suitable
👨‍💻 Refactor: Improve pause/resume logic on connection interruption/reconnect
📔 Docs: Updated and refactored docs with better examples
📔 Docs: Refactored JSDoc matching definitions in TypeScript
🤓 Dev: Improved TypeScript support
👷‍♂️ Dev: Improved debugging logs
👨‍🔬 Tests: Improved test-suite
👷‍♂️ Git: CI GitHub Action Workflows for lint and build tests

Major changes

FilesCollection:

⚠️ FilesCollection#remove() — deprecated on server, use FilesCollection#removeAsync instead
⚠️ FilesCollection#findOne() — deprecated on server, use FilesCollection#findOneAsync instead
⚠️ FilesCollection#unlink() — deprecated on server, use FilesCollection#unlinkAsync instead
⚠️ FilesCollection#write() — deprecated on server, use FilesCollection#writeAsync instead
⚠️ FilesCollection#load() — deprecated on server, use FilesCollection#loadAsync instead

FileCursor:

⚠️ FileCursor#remove() — deprecated on server, use FileCursor#removeAsync instead

FilesCursor:

⚠️ FilesCursor#remove() — deprecated on server, use FilesCursor#removeAsync instead
⚠️ FilesCursor#hasNext() - deprecated, use FilesCursor#hasNextAsync instead
⚠️ FilesCursor#count() - deprecated, use FilesCursor#countDocuments instead
⚠️ FilesCursor#countAsync() - deprecated, use FilesCursor#countDocuments instead

FileUpload:

⚠️ FileUpload#start() is now async!

Callbacks and hooks:

⚠️ Anywhere: this.user() is deprecated, use this.userAsync() instead
⚠️ Client: FileUpload now always triggers end even in the case of successful and failed uploads; Before: end event wasn't called under certain conditions
⚠️ Client: All errors appeared during upload in all hooks and events of FileUpload are now instance of Meteor.Error; Before: Errors had mixed type or were simply text
⚠️ Client: Errors are the same now (type, code, text, reason, details) within DDP and HTTP protocols; Before: DDP and HTTP protocols had different errors
⚠️ Client: The next private events were removed from UploadInstance Class: upload, sendEOF, prepare, sendChunk, proceedChunk

New methods

FilesCollection:

✨ Client: FilesCollection#insertAsync()
✨ Anywhere: FilesCollection#updateAsync()
✨ Anywhere: FilesCollection#removeAsync()
✨ Anywhere: FilesCollection#findOneAsync()
✨ Anywhere: FilesCollection#countDocuments()
✨ Anywhere: FilesCollection#estimatedDocumentCount()
✨ Server: FilesCollection#unlinkAsync()
✨ Server: FilesCollection#writeAsync()
✨ Server: FilesCollection#loadAsync()

FileCursor:

✨ Anywhere: FileCursor#removeAsync()
✨ Anywhere: FileCursor#fetchAsync()

FilesCursor:

✨ Anywhere: FilesCursor#getAsync()
✨ Anywhere: FilesCursor#hasNextAsync()
✨ Anywhere: FilesCursor#nextAsync()
✨ Anywhere: FilesCursor#hasPreviousAsync()
✨ Anywhere: FilesCursor#previousAsync()
✨ Anywhere: FilesCursor#removeAsync()
✨ Anywhere: FilesCursor#fetchAsync()
✨ Anywhere: FilesCursor#firstAsync()
✨ Anywhere: FilesCursor#lastAsync()
✨ Anywhere: FilesCursor#countDocuments()
✨ Anywhere: FilesCursor#forEachAsync()
✨ Anywhere: FilesCursor#eachAsync()
✨ Anywhere: FilesCursor#mapAsync()
✨ Anywhere: FilesCursor#currentAsync()
✨ Anywhere: FilesCursor#observeAsync()
✨ Anywhere: FilesCursor#observeChangesAsync()

New features

✨ Client: FileUpload#remainingTime ReactiveVar — returns remaining upload time in hh:mm:ss format;

Other changes

🔧 Security: Fixed TLS cookie without secure flag set - x_mtok #894 — now x_mtok cookie is set with secure and httpOnly flags
🔧 Refactor: Fixed FileCursor#with implementation
✨ Refactor: FileUpload#abort is now async
✨ Server: FilesCollection#addFile is now async
✨ Server: FilesCollection#download is now async
✨ Server: WriteStream Class is now available for import
⚙️ Client: disableUpload option processed on the client and returns error in the end/error events, and onError hooks. Before — throws an error upon calling .insert() method

Dependencies

release:

[email protected], was 4.0.7
removed: abort-controller, now using native AbortController
removed: fs-extra, now using native fs

dev:

added: [email protected]
added: [email protected]

harryadel · 2025-04-02T15:08:32Z

I've just used the latest RC in our project. The only thing we had to change really was unlink to unlinkAsync which was about 3 calls. So far so good, I'll report back if I find any issues in the upcoming days. Thank you all for pushing this through.

dr-dimitru · 2025-04-02T15:13:58Z

@harryadel awesome, thank you for feedback. Do you use protected other this.user() in any callback's contexts? Have some reports that this one is broken

harryadel · 2025-04-02T15:24:15Z

@harryadel awesome, thank you for feedback. Do you use protected other this.user() in any callback's contexts? Have some reports that this one is broken

No, I don't think we really do.

Update GridFS exmaple code

dr-dimitru and others added 30 commits June 29, 2022 16:08

Merge pull request #845 from veliovgroup/dev

313e842

📦 v2.2.1 - 👨‍💻 Fix #842, a newly detected bug by @chrschae; Fixing case when `namingFunction` returns new nested path cause exception in `.write()` and `.load()` methods

Merge pull request #859 from veliovgroup/dev

df7a6c9

📔 Improve AWS S3 documentation

Merge pull request #860 from veliovgroup/dev

4f58852

📦 v2.3.2 - 👨‍💻 Potential fix for #857 (windows)

Merge pull request #864 from veliovgroup/dev

b312ef9

👷‍♂️ Update .eslintrc

Merge pull request #871 from veliovgroup/dev

49f3bed

📦 v2.3.3 __Major changes:__ - no __Changes:__ - 👨‍🔧 Fixed #870, thanks to @Gobliins - 🤝 Compatibility with `[email protected]`

implement async methods

93b7a73

getLink async

a6c6da3

lint fix

926e8e2

fix Match.OneOf etc lint rule

c811a75

tiny tests npm script

b37aba8

added some mocha testing

f7bbba1

script for mocha

4af4af6

Merge remote-tracking branch 'original-meteor-files/dev'

aac6555

tests

e502124

few more tests

91fbf48

link() is not async

c7fe2a3

more tests, remove tests fails

5c31934

fixed tests

743c12f

rest of cursor tests

ff30780

few more tests

1ea4e38

Add devDependencies and update removeAsync method

bf63873

addFileAsync

e727ae8

test for download

3edc652

downloadAsync tests

f97b4a9

prepareUploadAsync

497e8c2

_finishUploadAsync and tests

2dfa4de

removed style changes

03e9ac7

dr-dimitru added 10 commits March 26, 2025 19:02

📔 fix: JSDoc definitions

6e017fb

✨ feat: FileUpload#remainingTime ReactiveVar

07c01d9

- Add `remainingTime` ReactiveVar to `FileUpload` instance with `hh:mm:ss` remaining upload time format

📦 v3.0.0-RC.1

5bb60b8

- Various fixes and improvements - Attempt to fix GitHub Actions

👷‍♂️ fix: github actions

a62eeac

👷‍♂️ fix: github actions linter

e779288

👷‍♂️ add: .eslintrc to fix github action lint

66a7232

👷‍♂️ fix: issues raised by github actions lint

8c6b9bc

👷‍♂️ fix: issues raised by github actions lint

77d1cf7

👨‍💻 fix: #894 (secure cookie)

217b269

- Set `x_mtok` cookie to `secure` and `httpOnly`, thanks to @mfeuermann

📦 v3.0.0-RC.1

5f4f9a9

dr-dimitru added 9 commits March 27, 2025 19:24

🔥 hotfix: FileCursor#remove method

00474cc

- return `callback` argument back to `FileCursor#remove` method

📔 docs: JSDoc update

2cc8884

👨‍💻 refactor: minor fixes

43ab154

🔥 hotfix: Client namingFunction is now async

7b25b7f

📔 docs: GridFS integration

82f87be

👨‍🔬 tests: async chmod has no callback

2dafe6d

📔 docs: minor update

7b055d1

📔 docs: README update

ef7759b

📦 v3.0.0-RC.3

1900ecc

dr-dimitru and others added 4 commits March 28, 2025 00:47

👨‍🔬 tests: fix lint warnings

e60462a

📔 docs: README update

be748d4

📔 docs: README update

e502dc0

Update GridFS exmaple code

c2b7b75

harryadel and others added 2 commits April 2, 2025 18:22

Apply the doctor prescription

3384ff4

Merge pull request #900 from harryadel/update-document

1ed12d1

Update GridFS exmaple code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

async/await support and other changes for meteor@3 #895

async/await support and other changes for meteor@3 #895

dr-dimitru commented Jan 19, 2025

dr-dimitru commented Mar 26, 2025

dr-dimitru commented Mar 27, 2025

harryadel commented Apr 2, 2025

dr-dimitru commented Apr 2, 2025

harryadel commented Apr 2, 2025

async/await support and other changes for meteor@3 #895

Are you sure you want to change the base?

async/await support and other changes for meteor@3 #895

Conversation

dr-dimitru commented Jan 19, 2025

dr-dimitru commented Mar 26, 2025

dr-dimitru commented Mar 27, 2025

Summary

Major changes

New methods

New features

Other changes

Dependencies

harryadel commented Apr 2, 2025

dr-dimitru commented Apr 2, 2025

harryadel commented Apr 2, 2025