feat: support next.config.ts #50126
Closed
feat: support next.config.ts #50126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helbing
requested review from
a team,
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
|
@ijjk Can you review this PR? |
|
Notifying the following users due to files changed in this PR: @timneutkens, @ijjk, @shuding, @styfle, @huozhi: This comment was posted based on the notify modifier. |
|
Could this PR be reviewed? |
timneutkens
requested changes
Jul 17, 2023
There was a problem hiding this comment.
This PR is introducing additional dependencies, e.g. jiti and sucrase and causes a divergence between how TypeScript is handled in next.config.ts and the application, these should be the same as otherwise application code will behave differently. I.e. you'll have to run webpack on the next.config.ts with the same configuration as the application code and then run the require on the output bundle.
This was referenced Mar 3, 2024
devjiwonchoi
added a commit
that referenced
this pull request
Jul 9, 2024
> Note: port of #57656 ## What? This PR initiated support of `next.config.ts`. Follow ups: - update docs ([x-ref](2ea9b6e)) - update cna ts templates ([x-ref](80e6740)) ## Why? > Next.js provides a TypeScript-first development experience for building your React application. This PR can resolve the two main needs: 1. Import TS files to the config. 2. Conduct a type check directly by importing `type` instead of JSDoc. x-ref: #5318 #35969 #44632 #50121 #50126 ## How? ### Goals - [x] [do not bundle](#57656 (comment)) - [x] [minimum fs operations](#63051 (comment)) - [x] zero restrictions Used `require.extensions` hooks to transpile the imported files on the fly. To reduce I/O operation on disk, used custom `module.exports` to require directly from a transpiled code string. ## Expected > Added tests for the cases below: - [x] export default - [x] export config `as default` - [x] [config as an async function](https://nextjs.org/docs/app/api-reference/next-config-js) - [x] use Node.js modules (fs, path, etc.) - [x] HMR on config change - [x] throw when type error - [x] turbopack ### Importing Files - [x] nested imports (config -> A -> B) - [x] import alias (tsconfig baseUrl and paths) - [x] import from `node_modules` - [x] import `JSON` #### Extensions - [x] `.ts` - [x] `.cts` - [x] `.mts` - [x] `.cjs` - [x] `.mjs` - [x] `.js` (both ESM and CJS w/o extra change) --------- Co-authored-by: Donny/강동윤 <[email protected]> Co-authored-by: Sukka <[email protected]> Co-authored-by: JJ Kasper <[email protected]> Co-authored-by: Sam Ko <[email protected]> Co-authored-by: Ahmed Abdelbaset <[email protected]> Co-authored-by: JJ Kasper <[email protected]>
|
Closing due to #63051, thank you for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support
next.config.ts, related to discusses #50121