Skip to content

Handle no summary features when trying to select elements by summary … #34277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Handle no summary features when trying to select elements by summary … #34277

merged 1 commit into from
Jun 14, 2025
+8 −0

Conversation

toregge
Copy link
Member

@toregge toregge commented Jun 13, 2025

…feature.

@vekterli : please review
@havardpe : FYI

@toregge toregge requested a review from vekterli June 13, 2025 19:30
vekterli
vekterli approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@vekterli vekterli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 it would be nice to have a test for this particular edge case

@vekterli vekterli merged commit 7789c5e into master Jun 14, 2025
3 checks passed
@vekterli vekterli deleted the toregge/handle-no-summary-features branch June 14, 2025 10:15
@toregge toregge mentioned this pull request Jun 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vekterli vekterli vekterli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toregge @vekterli