Skip to content

make new timing change backward-compatible #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2022
Merged

make new timing change backward-compatible #24

merged 4 commits into from
Dec 3, 2022

Conversation

vilterp
Copy link
Owner

@vilterp vilterp commented Nov 21, 2022 •
edited
Loading

Merges into JuliaLang#47615, attempting to make it backward-compatible

TODO:

  • print deprecation warning (println and @warn are undefined in the compiler)

@vilterp vilterp changed the base branch from master to pv-compiler-timings-lock November 21, 2022 23:11
NHDaly
NHDaly reviewed Nov 21, 2022
View reviewed changes
vilterp and others added 2 commits November 21, 2022 18:24
@vilterp
tweaks
16aaf30
@NHDaly
Perf: allocs reduction in type inference profiling
ce8bb69 
Don't copy the vectors just for the assertion.
@NHDaly
Copy link
Collaborator

NHDaly commented Dec 3, 2022

I think we can merge this PR now, since we're using it in our codebase and it's working well, yeah?

@vilterp vilterp marked this pull request as ready for review December 3, 2022 20:21
@vilterp
Copy link
Owner Author

vilterp commented Dec 3, 2022

Yep yep

@vilterp vilterp merged commit 8cf3a57 into pv-compiler-timings-lock Dec 3, 2022
@NHDaly NHDaly deleted the pv-compiler-timings-lock-backcompat branch December 4, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHDaly NHDaly NHDaly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vilterp @NHDaly