chore: include sharp to pnpm built dependencies #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to run
pnpm approve-buildsto allow runplayground-assets: once we runpnpm approve-buildsand selectsharp, the build folder with the corresponding binary is added when running the sharp install script.pnpmwill add sharp to the workspace entry and sharp binaries will be installed when runnung thepnpminstall script (I need to test it with this branch, tested only on my local 🤞 )Linked Issues
Additional Context
playground-assets error
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.