test(react): wait for hmr update to reduce flakyness #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following test failed some times in the following condition
vite-plugin-react/playground/react/__tests__/react.spec.ts
Lines 74 to 94 in ce0de3e
vite-plugin-react/playground/react/__tests__/react.spec.ts
Lines 49 to 51 in a758bfe
vite-plugin-react/playground/react/__tests__/react.spec.ts
Lines 73 to 75 in a758bfe
In that case,
allExportsAreComponentsOrUnchanged
probably becomestrue
because ofprevExports[key] === nextExports[key]
, andimport.meta.hot.invalidate
won't be called.vite-plugin-react/packages/common/refresh-runtime.js
Line 615 in a758bfe
This PR fixes that flaky fail by waiting for the update to be processed.