feat!: make import.meta.hot.send
async
#18750
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error that happened inside
send
method ofModuleRunnerTransport
was not able to handle.This PR fixes that by
await
ing on thesend
method. This requires theimport.meta.hot.send
to be alsoawait
ed (thus a breaking change). Thisawait
was not required in Vite 5 because we only used WS and WS's send is sync. In #18362, I made the ModuleRunnerTransport to allow asyncsend
just because I thought there may be a place that require async and didn't find any breaking change by doing so.Alternative way to solve this is #18751.