Skip to content

feat!: make import.meta.hot.send async #18750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 25, 2024

Description

The error that happened inside send method of ModuleRunnerTransport was not able to handle.

This PR fixes that by awaiting on the send method. This requires the import.meta.hot.send to be also awaited (thus a breaking change). This await was not required in Vite 5 because we only used WS and WS's send is sync. In #18362, I made the ModuleRunnerTransport to allow async send just because I thought there may be a place that require async and didn't find any breaking change by doing so.

Alternative way to solve this is #18751.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) breaking change labels Nov 25, 2024
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 2b692b7: Open

suite result latest scheduled
astro failure failure
histoire failure failure
redwoodjs failure failure
remix failure failure
sveltekit failure failure
vike failure failure
vitest failure success
waku failure failure

analogjs, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

@sapphi-red
Copy link
Member Author

closing as #18753 was merged

@sapphi-red sapphi-red closed this Nov 26, 2024
@sapphi-red sapphi-red deleted the feat/make-import-meta-hot-send-async branch November 26, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant