fix: ignore malformed uris in tranform middleware #19853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
reviewed
Apr 14, 2025
sapphi-red
added
the
p2-edge-case
sapphi-red
changed the title
sapphi-red
approved these changes
Apr 15, 2025
hi-ogawa
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
I wonder what else error can happen in the little snippet, but catching it makes sense to me 👍
(Also linking Vitest issue vitest-dev/vitest#7788 since we just recently discussed we need a similar decodeURI somewhere for Vitest browser mode)
Most things happening in that try block are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19848
(might want to squash these commits lol)