-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Frontend] Add /classify endpoint #17032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments. Can you also add an example script to examples/online_serving
to show how to use this endpoint?
Yes! It's |
Oh, right. Sorry I missed that |
Signed-off-by: Frieda (Jingying) Huang <[email protected]>
Really appreciate the feedback! I’ve implemented your suggestions in the latest commit. I’ve noticed that |
logger = init_logger(__name__) | ||
|
||
|
||
class OpenAIServingClassification(OpenAIServing): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really following OpenAI API so let's rename this to ServingClassification
Sure! |
FIX #13567 (#13567)