Skip to content

[Frontend] Add /classify endpoint #17032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

frieda-huang
Copy link

@frieda-huang frieda-huang commented Apr 23, 2025

FIX #13567 (#13567)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Apr 23, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. Can you also add an example script to examples/online_serving to show how to use this endpoint?

@frieda-huang
Copy link
Author

frieda-huang commented Apr 23, 2025

Some initial comments. Can you also add an example script to examples/online_serving to show how to use this endpoint?

Yes! It's openai_classification_client.py under examples/online_serving.

@DarkLight1337
Copy link
Member

examples/online_serving to show how to use this endpoint?

Oh, right. Sorry I missed that

@frieda-huang
Copy link
Author

frieda-huang commented Apr 23, 2025

examples/online_serving to show how to use this endpoint?

Oh, right. Sorry I missed that

Really appreciate the feedback! I’ve implemented your suggestions in the latest commit.

I’ve noticed that serving_classification.py, serving_score.py, serving_transcription.py, and serving_embedding.py all share the same pattern of input preprocessing, request scheduling, and result‑generator aggregation. Should we move that pipeline into a shared helper or abstract base class?

logger = init_logger(__name__)


class OpenAIServingClassification(OpenAIServing):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really following OpenAI API so let's rename this to ServingClassification

@DarkLight1337
Copy link
Member

I’ve noticed that serving_classification.py, serving_score.py, serving_transcription.py, and serving_embedding.py all share the same pattern of input preprocessing, request scheduling, and result‑generator aggregation. Should we move that pipeline into a shared helper or abstract base class?

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support for Running Classification Task in Online Server
2 participants