Skip to content

Addendum Fix to support FIPS enabled machines with MD5 hashing #17043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

sydarb
Copy link
Contributor

@sydarb sydarb commented Apr 23, 2025

Complete FIPS compliance fixes for MD5 hashing

This PR completes the work started in the previous merge (#15299), which addressed the issue of FIPS-enabled machines prohibiting MD5 hashing. The previous PR used the usedforsecurity=False flag with hashlib.md5() to resolve the issue, but it missed applying this change in a few locations within the codebase. The following changes ensure full compliance with FIPS requirements across the entire library.

FIX #17031

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@russellb russellb enabled auto-merge (squash) April 23, 2025 18:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 23, 2025
@vllm-bot vllm-bot merged commit ed2e464 into vllm-project:main Apr 24, 2025
84 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ValueError: Model architectures ['OPTForCausalLM'] failed to be inspected.
3 participants