This repository was archived by the owner on Dec 15, 2021. It is now read-only.
Update use-existing-kafka.md #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding an example configuration for SSL based connectivity for Kafka Triggers
andresmgot
reviewed
Jul 1, 2019
| @@ -171,3 +171,38 @@ When using SSL to secure kafka communication, you must set `KAFKA_ENABLE_TLS`, a | |||
| * `KAFKA_CACERTS` to check server certificate | |||
| * `KAFKA_CERT` and `KAFKA_KEY` to check client certificate | |||
| * `KAFKA_INSECURE` to skip TLS verfication | |||
| ```yaml | |||
There was a problem hiding this comment.
would you mind adding some paragraph before doing what you are setting here? Something like "Below you can find an example of a Kafka controller deployment using TLS"
docs/use-existing-kafka.md
Outdated
| @@ -171,3 +171,38 @@ When using SSL to secure kafka communication, you must set `KAFKA_ENABLE_TLS`, a | |||
| * `KAFKA_CACERTS` to check server certificate | |||
| * `KAFKA_CERT` and `KAFKA_KEY` to check client certificate | |||
| * `KAFKA_INSECURE` to skip TLS verfication | |||
| ```yaml | |||
| $ echo ' | |||
There was a problem hiding this comment.
I think you can remove the $echo ' part (I know it's like that in the other example but it's not clarifying anything
docs/use-existing-kafka.md
Outdated
| env: | ||
| ... | ||
| - name: KAFKA_ENABLE_TLS | ||
| value: "true" # CHANGE THIS! |
There was a problem hiding this comment.
If you are using TLS this should be "true" right? Why are you setting the comment CHANGE THIS?
| value: "/path/to/cert.pem" # CHANGE THIS! (MAKE SURE PATH ARE VOLUME MOUNTED SAY FROM SECRETS) | ||
| - name: KAFKA_KEY | ||
| value: "/path/to/key.pem" # CHANGE THIS! (MAKE SURE PATH ARE VOLUME MOUNTED SAY FROM SECRETS) | ||
| ... |
There was a problem hiding this comment.
Would you mind adding the volumeMounts and volumes section? So people know these files come from a Secret.
Done Changes
andresmgot
approved these changes
Jul 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an example configuration for SSL based connectivity for Kafka Triggers
Issue Ref: [Issue number related to this PR or None]
Description:
[PR Description]
TODOs: