Skip to content

Build container image with every release #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
migmartri opened this issue Jan 11, 2022 · 2 comments · Fixed by #131
Closed
2 tasks done

Build container image with every release #127

migmartri opened this issue Jan 11, 2022 · 2 comments · Fixed by #131
Assignees

Comments

@migmartri
Copy link
Contributor

migmartri commented Jan 11, 2022

Apart of the binary release now performed by a github action using goreleaser, we also want to offer a container image that contains the binary already bundled in, so it can be easily used in CI usecases for example.

Up until the migration of the release process from the internal infra to github actions, we have been offering the image through distribution harbor in this URI http://projects.registry.vmware.com/tanzu_isv_engineering/relok8s

The issue with that location is that it requires pushing from within VMware's VPN, which rules out the possibility of allowing the external build process (the current one using goreleaser) to be the one building and pushing the image.

That's why I suggest to also move that process to be hosted at https://github.com/features/packages, similarly to what kapp-controller does.

The task will be

  • Update goreleaser to build and push the container image to github packages
  • Update our runway pipeline to trigger relocate-helm-chart test from those images instead

cc/ @josvazg @petewall

@migmartri
Copy link
Contributor Author

@migmartri migmartri self-assigned this Jan 11, 2022
@migmartri
Copy link
Contributor Author

Actually nevermind, it's not needed, I managed to push the image and connect it to the repo via labels

docker pull ghcr.io/vmware-tanzu/asset-relocation-tool-for-kubernetes:latest

migmartri pushed a commit that referenced this issue Jan 11, 2022
Update readme to indicate both installation methods

Refs #127
migmartri pushed a commit that referenced this issue Jan 11, 2022
Update readme to indicate both installation methods

Refs #127

Signed-off-by: Miguel Martinez Trivino <[email protected]>
migmartri pushed a commit that referenced this issue Jan 12, 2022
* chore: installation methods in readme

Update readme to indicate both installation methods

Refs #127

Signed-off-by: Miguel Martinez Trivino <[email protected]>

* fix readme

Signed-off-by: Miguel Martinez Trivino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant