Skip to content

Upgrade to Go 1.18 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 20, 2022
Merged

Upgrade to Go 1.18 #150

merged 3 commits into from
Apr 20, 2022

Conversation

josvazg
Copy link
Contributor

@josvazg josvazg commented Apr 17, 2022 •
edited
Loading

Also let it still support 1.17 to ease upgrade.

Going forward we should aim to support the same latest 2 Go versions that the Go team actively supports.

Signed-off-by: Jose Luis Vazquez Gonzalez [email protected]

@josvazg josvazg marked this pull request as draft April 17, 2022 17:55
@vmwclabot
Copy link

@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@josvazg josvazg changed the base branch from main to order-charts April 19, 2022 16:41
@vmwclabot
Copy link

@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@josvazg josvazg force-pushed the upgrade-go-1.18 branch 2 times, most recently from 98ced60 to 4de8b2c Compare April 19, 2022 21:12
@vmwclabot
Copy link

@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link

@josvazg, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@josvazg josvazg changed the base branch from order-charts to main April 20, 2022 07:11
Jose Luis Vazquez Gonzalez added 3 commits April 20, 2022 09:20
Upgrade to Go 1.18
cd1e77b 
Signed-off-by: Jose Luis Vazquez Gonzalez <[email protected]>
Move to a minimum version check with build tags
81907eb 
Signed-off-by: Jose Luis Vazquez Gonzalez <[email protected]>
Support 2 Go versions
07d5338 
Signed-off-by: Jose Luis Vazquez Gonzalez <[email protected]>
@josvazg josvazg marked this pull request as ready for review April 20, 2022 07:58
petewall
petewall reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josvazg josvazg merged commit b4b4723 into main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petewall petewall petewall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josvazg @vmwclabot @petewall