Skip to content

say goodbye to beego v1 because it has security issue #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

JingChen23
Copy link
Contributor

@JingChen23 JingChen23 commented Feb 24, 2023

Check this as the background.

Beego 1 has critical security issue.

Beego is used by the harbor source code. So I go get the latest harbor source code, in which they have switched to beego v2.

This is the pr of harbor.

goharbor/harbor#17801

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ac73485). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage        ?   43.70%           
=======================================
  Files           ?       10           
  Lines           ?     1167           
  Branches        ?        0           
=======================================
  Hits            ?      510           
  Misses          ?      624           
  Partials        ?       33           
Flag Coverage Δ
unittests 43.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JingChen23
Copy link
Contributor Author

JingChen23 commented Feb 24, 2023

The Cypress failure is a known issue, has been fixed on develop-0.3, let me cherry pick that commit.

Copy link
Contributor

@4everming 4everming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JingChen23 JingChen23 merged commit 6dd414d into vmware-tanzu:main Feb 24, 2023
@JingChen23 JingChen23 deleted the fix-beego-security branch March 7, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants