Remove cache stores for VPCNetworkConfig #1025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanjunz97
force-pushed
the
rm-vpcconfig-cache
branch
from
9671225 to
0648db5
Compare
|
/e2e |
1 similar comment
|
/e2e |
yanjunz97
force-pushed
the
rm-vpcconfig-cache
branch
from
0648db5 to
776f18b
Compare
yanjunz97
force-pushed
the
rm-vpcconfig-cache
branch
2 times, most recently
from
6fe027e to
1e165d5
Compare
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
yanjunz97
force-pushed
the
rm-vpcconfig-cache
branch
2 times, most recently
from
518b665 to
b119538
Compare
Signed-off-by: Yanjun Zhou <[email protected]>
Signed-off-by: Yanjun Zhou <[email protected]>
yanjunz97
force-pushed
the
rm-vpcconfig-cache
branch
from
b119538 to
ef13639
Compare
TaoZou1
reviewed
Feb 26, 2025
| log.Info("Failed to get network config info using network config name", "Name", ncName) | ||
| return nil | ||
| log.Info("Network config info does not exist", "Name", ncName) | ||
| return nil, nil |
There was a problem hiding this comment.
how about use 'NetworkConfig' for line 122/118?
There was a problem hiding this comment.
Sounds good. There are many occurrence of network config, I replaced them all by NetworkConfig, thanks
pkg/nsx/services/vpc/vpc.go
Outdated
| } | ||
|
|
||
| func IsPreCreatedVPC(nc common.VPCNetworkConfigInfo) bool { | ||
| return nc.VPCPath != "" | ||
| } | ||
|
|
||
| func buildNetworkConfigInfo(vpcConfigCR *v1alpha1.VPCNetworkConfiguration) (*common.VPCNetworkConfigInfo, error) { | ||
| org, project, err := nsxProjectPathToId(vpcConfigCR.Spec.NSXProject) |
pkg/nsx/services/vpc/vpc.go
Outdated
|
|
||
| func isDefaultNetworkConfigCR(vpcConfigCR *v1alpha1.VPCNetworkConfiguration) bool { | ||
| annos := vpcConfigCR.GetAnnotations() | ||
| val, exist := annos[common.AnnotationDefaultNetworkConfig] |
There was a problem hiding this comment.
the same function isDefaultNetworkConfigCR/nsxProjectPathToId in the vpcnetworkconfig_handler.go, could you reuse them?
There was a problem hiding this comment.
These 2 functions are not used in vpcnetworkconfig_handler, removed them, thanks!
Signed-off-by: Yanjun Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current we maintain 2 caches, VPCNSNetworkConfigStore and VPCNetworkConfigStore,
for mapping between Namespace, VPCNetworkConfig name and VPCNetworkConfig Info.
But those information are parsed based Namespace and VPCNetworkConfig CRs, which
are cached in controller runtime client. Thus we remove the cache in NSX Operator and
rely on controller runtime client cache to get those information.
Testing done:
Create a Namespace and create VM on the Namespace. The VM can power on with IP.