Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: build-image-hugo: add --load for docker-container driver #8702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaovilai
Copy link
Member

Thank you for contributing to Velero!

Please add a summary of your change

To solve warning when using docker-container driver

WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load

Signed-off-by: Tiger Kaovilai [email protected]

Does your change fix a particular issue?

N/A

Please indicate you've done the following:

@kaovilai kaovilai added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Feb 18, 2025
@kaovilai kaovilai marked this pull request as ready for review February 18, 2025 22:00
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.48%. Comparing base (e64806a) to head (d2ac092).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8702   +/-   ##
=======================================
  Coverage   59.48%   59.48%           
=======================================
  Files         371      371           
  Lines       40191    40191           
=======================================
  Hits        23909    23909           
  Misses      14789    14789           
  Partials     1493     1493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor

Please rebase to resolve the failed checks.

To solve warning when using [docker-container driver](https://docs.docker.com/build/builders/drivers/docker-container/)
```
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
```

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the dockerbuildloadhugo branch from ccea2d1 to d2ac092 Compare February 20, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants