Add velero namespace to the exclusion list of backup tasks #8716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult; 2. After self-protection feature， we will change it.
hu-keyu
changed the title
hu-keyu
changed the title
Lyndon-Li
reviewed
Feb 21, 2025
| if err := b.kbClient.Get(context.Background(), kbclient.ObjectKey{Name: backup.GetNamespace()}, &backupNamespace); err != nil { | ||
| request.Status.ValidationErrors = append(request.Status.ValidationErrors, fmt.Sprintf("error getting backup namespace: %v", err)) | ||
| } else { | ||
| request.Spec.ExcludedNamespaces = append(request.Spec.ExcludedNamespaces, backupNamespace.Name) |
There was a problem hiding this comment.
We cannot simply exclude Velero namespace from backup, some resources are created into Velero namespace dynamically and still need to be backed up, i.e., dataupload, podvolumebackup, volumesnapshot, etc. This mechanism will be used widerly and is implemented as part of internal logics, instead of directly requested by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.