⚠️ Remove UpdateConfigSpecFirmware() #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyar85
approved these changes
Feb 20, 2025
This is from the early days when we could only update the VM's Firmware - and most things for that matter - after the VM was created since Content Library did not support creating from a ConfigSpec. Since now CL supports that, and some time back I added support in CreateConfigSpec() for the firmware annotation, so the VM is just created with the specified firmware. Changing the firmware of existing VM is generally not going to result in a booting VM, so at the moment I didn't implement similar support in resize.
bryanv
force-pushed
the
bryanv/remove-post-create-firmware-annoation-check
branch
from
3450767 to
3412e75
Compare
Minimum allowed line rate is |
aruneshpa
approved these changes
Feb 27, 2025
akutz
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
@bryanv We support specifying the firmware in the spec anyway, right?
Huh, we do not. I know I wanted to add it. It will likely come in via the parity DevOps settings, and that may involve allowing a user to reconfigure the firmware if they want. We'd certainly need to allow it during a resize. Therefore we will need to consider firmware during update eventually, but since it would be different enough than the current code I see no reason not to proceed with this PR as-is today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This is from the early days when we could only update the VM's Firmware - and most things for that matter - after the VM was created since Content Library did not support creating from a ConfigSpec. Since now CL supports that, and some time back I added support in CreateConfigSpec() for the firmware annotation, so the VM is just created with the specified firmware.
Changing the firmware of existing VM is generally not going to result in a booting VM, so at the moment I didn't implement similar support in resize. My preference would be to remove this.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
I want to start to reworking the entire VM create/update unit tests so they can be run with resize enabled and disabled. This is one the deltas. It is easy enough to add this as a dev ops resize overwrite if we want to keep things the same instead.
Please add a release note if necessary: