🌱 Add resize MatchVirtualDevice placeholder #893
+599
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
force-pushed
the
bryanv/resize-match-virtual-device-placeholder
branch
3 times, most recently
from
91d9ca1 to
04d8e64
Compare
github-actions
bot
added
size/XL
bryanv
force-pushed
the
bryanv/resize-match-virtual-device-placeholder
branch
3 times, most recently
from
a1d40a6 to
4461bd9
Compare
For some upcoming work, we'll need to compare fields in the base VirtualDevice/VirtualController (besides the backing) so wire that up now. I expect to use the cmp*Edit funcs in some later work so keep them around but add explicit unit tests for them.
bryanv
force-pushed
the
bryanv/resize-match-virtual-device-placeholder
branch
from
4461bd9 to
a6aac35
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
For some upcoming work, we'll need to compare fields in the base VirtualDevice/VirtualController (besides the backing) so wire that up now. Commonize how we were doing the was device edited check deviceEdited().
I expect to use the cmp*Edit funcs in some later work so keep them around but add explicit unit tests for them.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: